“Scotland’s capital is a photographer’s dream: viewpoints to die for, gorgeous sandstone everywhere and a sense of idiosyncrasy that’s perfect to capture”